[PATCH] D51026: [CodeGen] Implicitly set stackrealign on the main function, if custom stack alignment is used
Martin Storsjö via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 21 06:06:02 PDT 2018
mstorsjo added inline comments.
================
Comment at: lib/CodeGen/CodeGenFunction.cpp:989
+ CGM.getCodeGenOpts().StackAlignment)
+ Fn->addFnAttr("stackrealign");
+
----------------
erichkeane wrote:
> Is there not an attribute name for this already in LLVM? I guess I'm otherwise fine with this, but would want @craig.topper or @rnk to confirm that we're Ok just sending this string as an attribute.
I don't see one in llvm/include/llvm/IR/Attributes.td at least, and all other occurrances in clang just use the plain string.
Repository:
rC Clang
https://reviews.llvm.org/D51026
More information about the cfe-commits
mailing list