[PATCH] D50898: [clangd] Suggest code-completions for overriding base class virtual methods.
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 21 03:44:23 PDT 2018
kadircet marked an inline comment as done.
kadircet added inline comments.
================
Comment at: clangd/CodeComplete.cpp:1233
+ // struct/class/union definition.
+ const auto Overrides = getVirtualNonOverridenMethods(
+ Recorder->CCSema->CurContext, Recorder->CCSema);
----------------
hokein wrote:
> It seems that we treat it as a special case, the code path here runs out of the `ranking` path.
Put override suggestions to ranking system.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50898
More information about the cfe-commits
mailing list