[PATCH] D50897: [clangd] Allow using experimental Dex index

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 21 03:18:37 PDT 2018


ioeric added inline comments.


================
Comment at: clang-tools-extra/clangd/index/MemIndex.h:50
 
+// FIXME(kbobyrev): Document this one.
+std::shared_ptr<std::vector<const Symbol *>>
----------------
Please add documentation.


================
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:96
 
+namespace {
+
----------------
Why the move? A chunk of code in the middle of flags seems strange.


https://reviews.llvm.org/D50897





More information about the cfe-commits mailing list