[PATCH] D50580: [clang-tidy] Abseil: no namespace check

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added inline comments.


================
Comment at: clang-tidy/abseil/AbseilMatcher.h:32
+  auto Filename = FileEntry->getName();
+  llvm::Regex RE("absl/(base|container|debugging|memory|meta|numeric|strings|"
+                 "synchronization|types|utiliy)");
----------------
hokein wrote:
> lebedev.ri wrote:
> > hokein wrote:
> > > The regex seems incomplete, we are missing `algorithm`, `time` subdirectory. 
> > So what happens if open the namespace in a file that is located in my personal `absl/base` directory?
> > It will be false-negatively not reported?
>  Yes, I'd say this is a known limitation.
Similarly, the check will break (start producing false-positives) as soon as a new directory is added to abseil proper.
I don't have any reliable idea on how to do this better, but the current solution seems rather suboptimal..


https://reviews.llvm.org/D50580