[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 21 01:31:50 PDT 2018


hokein added a subscriber: deannagarcia.
hokein added a comment.

Your patch seems have some comments unaddressed but you marked done.

About the abseil matcher stuff, you and @deannagarcia have an overlap, maybe just wait for https://reviews.llvm.org/D50580 to submit, and reuse the matcher in this patch?



================
Comment at: clang-tidy/abseil/NoInternalDepsCheck.cpp:24
+  auto &SourceManager = Finder->getASTContext().getSourceManager();
+  SourceLocation loc = Node.getBeginLoc();
+  if (loc.isInvalid())
----------------
nit: loc => Loc


https://reviews.llvm.org/D50542





More information about the cfe-commits mailing list