[PATCH] D50580: [clang-tidy] Abseil: no namespace check

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 21 01:20:54 PDT 2018


lebedev.ri added inline comments.


================
Comment at: clang-tidy/abseil/AbseilMatcher.h:32
+  auto Filename = FileEntry->getName();
+  llvm::Regex RE("absl/(base|container|debugging|memory|meta|numeric|strings|"
+                 "synchronization|types|utiliy)");
----------------
hokein wrote:
> The regex seems incomplete, we are missing `algorithm`, `time` subdirectory. 
So what happens if open the namespace in a file that is located in my personal `absl/base` directory?
It will be false-negatively not reported?


https://reviews.llvm.org/D50580





More information about the cfe-commits mailing list