[PATCH] D49885: Thread safety analysis: Allow relockable scopes

Delesley Hutchins via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 20 16:13:21 PDT 2018


delesley accepted this revision.
delesley added a comment.

This looks good to me.  Thanks for the patch.



================
Comment at: lib/Analysis/ThreadSafety.cpp:932
+      // We're relocking the underlying mutexes. Warn on double locking.
+      if (FSet.findLock(FactMan, UnderCp))
+        Handler.handleDoubleLock(DiagKind, UnderCp.toString(), entry.loc());
----------------
Minor nit.  Use curly braces on the if, to match the else.


Repository:
  rC Clang

https://reviews.llvm.org/D49885





More information about the cfe-commits mailing list