[PATCH] D50571: [clangd] add an extension field to LSP to transfer the diagnostic's category

João Távora via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 20 02:15:49 PDT 2018


joaotavora added a comment.
Herald added a subscriber: kadircet.

> LGTM. Let's watch out for possible breakages in any of the clients, though. I've checked VSCode and it seems to be fine with the added fields.

This isn't in the spec and broke the LSP client eglot (https://github.com/joaotavora/eglot/pull/81). Why don't you put this in the "source" field, or concat it to the "message" field.  Who can even use this information if it's not in the spec? Are clients supposed to code against every LSP server's whim?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D50571





More information about the cfe-commits mailing list