[PATCH] D50945: [Lex] Make HeaderMaps a unique_ptr vector

Kristina Brooks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 19 08:59:43 PDT 2018


kristina added a comment.

Given the context (class an file name itself) and documentation around the function, I don't think in this particular case it improves readability or maintainability, the lifetime of the `HeaderMap` is (IMHO) fairly obvious from the const qualifier and from the documentation of the function itself. I would say leave it as is.


Repository:
  rC Clang

https://reviews.llvm.org/D50945





More information about the cfe-commits mailing list