[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

[Steve O'Brien via Phabricator via cfe-commits]

elsteveogrande updated this revision to Diff 161370.
elsteveogrande added a comment.

Rebase + fix conflicts for very old diff.  Works again.

`ninja check-clang` with MSAN-enabled build:

Before:

  Failing Tests (2):
      Clang :: CodeGen/signed_metadata.cpp
      Clang :: Index/comment-to-html-xml-conversion.cpp
  
    Expected Passes    : 12777
    Expected Failures  : 19
    Unsupported Tests  : 291
    Unexpected Failures: 2
  FAILED: tools/clang/test/CMakeFiles/check-clang
  cd /data/users/steveo/llvm-ct/build/msan/clang/tools/clang/test && /bin/python2.7 /data/users/steveo/llvm-ct/build/msan/clang/./bin/llvm-lit -sv --param clang_site_config=/data/users/steveo/llvm-ct/build/msan/clang/tools/clang/test/lit.site.cfg --param USE_Z3_SOLVER=0 /data/users/steveo/llvm-ct/build/msan/clang/tools/clang/test
  ninja: build stopped: subcommand failed.

After:

  Failing Tests (1):
      Clang :: CodeGen/signed_metadata.cpp
  
    Expected Passes    : 12778
    Expected Failures  : 19
    Unsupported Tests  : 291
    Unexpected Failures: 1
  FAILED: tools/clang/test/CMakeFiles/check-clang
  cd /data/users/steveo/llvm-ct/build/msan/clang/tools/clang/test && /bin/python2.7 /data/users/steveo/llvm-ct/build/msan/clang/./bin/llvm-lit -sv --param clang_site_config=/data/users/steveo/llvm-ct/build/msan/clang/tools/clang/test/lit.site.cfg --param USE_Z3_SOLVER=0 /data/users/steveo/llvm-ct/build/msan/clang/tools/clang/test
  ninja: build stopped: subcommand failed.


Repository:
  rC Clang

https://reviews.llvm.org/D42043

Files:
  include/clang-c/CXString.h
  tools/c-index-test/c-index-test.c
  tools/libclang/CXString.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42043.161370.patch
Type: text/x-patch
Size: 30234 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180818/aae59edd/attachment-0001.bin>