[PATCH] D50337: [clangd] DexIndex implementation prototype

[Kirill Bobyrev via Phabricator via cfe-commits]

kbobyrev planned changes to this revision.
kbobyrev added a comment.

I should create another patch with True iterator to address the last comment.



================
Comment at: clang-tools-extra/clangd/index/dex/DexIndex.cpp:97
+    // Add OR iterator for scopes if the request contains scopes.
+    if (!Req.Scopes.empty()) {
+      TopLevelChildren.push_back(createScopeIterator(Req.Scopes));
----------------
ioeric wrote:
> I think we should let `createScopeIterator` handle empty scope list case; it can return an empty list anyway.
Yes, but it returns an iterator now and `OrIterator` (just like any other iterator) has to have non-empty list of children.


https://reviews.llvm.org/D50337