[PATCH] D50835: [clangd] Add parantheses while auto-completing functions.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clangd/CodeComplete.h:85
+
+  /// Enables cursor to be moved around according to completions needs even when
+  /// snippets are disabled. For example selecting a function with parameters as
----------------
kadircet wrote:
> ioeric wrote:
> > IIRC, the goal of this patch is to allow disabling snippet templates for function parameters while still allow appending `()` or `($0)` to function candidates. If that's still the case, I think what we want is probably an option like `DisableSnippetTemplateForFunctionArgs`? 
> Yeah, that makes totally more sense. Thanks!
- Maybe use positive option names to avoid double negation?
- Maybe also use a shorter name? E.g. removing 'template' and 'disable' from the name gives a name that does not look any worse: `FunctionArgSnippets`.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D50835