[PATCH] D50726: [clangd] Show function documentation in sigHelp

[Eric Liu via Phabricator via cfe-commits]

ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: clangd/CodeCompletionStrings.cpp:52
   // get this declaration, so we don't show documentation in that case.
   if (Result.Kind != CodeCompletionResult::RK_Declaration)
     return "";
----------------
`RK_Pattern` can also have declaration. Do we want to consider those?


================
Comment at: clangd/CodeCompletionStrings.cpp:57
+    return "";
+  return getDeclComment(Ctx, *Decl);
+}
----------------
nit: maybe `return Decl ? getDeclComment(...) : "";`


================
Comment at: clangd/CodeCompletionStrings.cpp:77
     return "";
   return Doc;
 }
----------------
nit: `return looksLikeDocComment(Doc) ? Doc : "";` 


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D50726