[PATCH] D50852: [clang-tidy] abseil-auto-make-unique

[Jonas Toth via Phabricator via cfe-commits]

JonasToth added a comment.

In https://reviews.llvm.org/D50852#1202774, @lebedev.ri wrote:

> 1. Please always upload all patches with full context.
> 2. There already is `modernize-use-auto`. Does it handle this case? Then this should be just an alias to that check. Else, i think it would be best to extend that one, and still alias.


I checked fast and `modernize-use-auto` does not catch this case.

> Just checking, was there some memo i missed that abseil-related checks are exempt from all the usual guidelines?

Because this check is really not abseil-library-specific.

I agree that this check is general for `make_...` templates. It should be either an addition to `modernize-use-auto` or `readability-` or so. What we do for such cases, where the check is generally useful and specific to a guideline at the same time is aliasing.

You can take a look at `hicpp-` module where most checks are actually aliases.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D50852