[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

[Hugo Gonzalez via Phabricator via cfe-commits]

hugoeg added inline comments.


================
Comment at: test/clang-tidy/abseil-fake-declarations.h:1
+namespace std {
+struct string {
----------------
hokein wrote:
> I'd expect this header file is used as as a real absl library file:
> 
> * create an `absl` directory in `test/clang-tidy/Inputs/`, and this directory is the abseil source root directory
> * use the real absl function/class names instead of some fake names in the header, e.g. this file could be `test/clang-tidy/Inputs/absl/strings/str_cat.h`.
> 
> This would make the lit test align with the real world case, and it could be helpful if you implement the `IsExpansionInAbseilHeader` matcher in this check. 
My mentors on the absl team told me to refrain from using real absl function/class names as I did originally. They would prefer I use fake names. I'd be happy to update the filename something real like str_cat.h though

I have been implementing IsExpansionInHeader for the past couple days and I hope to have it included on this patch by the end of the week. 


================
Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:19
+namespace absl {
+  void OpeningNamespace() {
+    strings_internal::InternalFunction();
----------------
hokein wrote:
> the style doesn't looks correct to me.
This is the style given from clang-format


https://reviews.llvm.org/D50542