[PATCH] D50700: [clangd] Generate better incomplete bigrams for the Dex index

[Eric Liu via Phabricator via cfe-commits]

ioeric added inline comments.


================
Comment at: clang-tools-extra/unittests/clangd/DexIndexTests.cpp:324
 
+  EXPECT_THAT(generateQueryTrigrams("u_p"), trigramsAre({"up$"}));
+  EXPECT_THAT(generateQueryTrigrams("_u_p"), trigramsAre({"_u_"}));
----------------
I'm not sure if this is correct. If users have explicitly typed `_`, they are likely to want a `_` there. You mentioned in the patch summary that users might want to match two heads with this. Could you provide an example?


https://reviews.llvm.org/D50700