[PATCH] D50727: [clangd] Fetch documentation from the Index during signature help
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 16 04:36:05 PDT 2018
ilya-biryukov added inline comments.
================
Comment at: clangd/CodeComplete.cpp:755
+ });
+ log("SigHelp: requested docs for {0} symbols from the index, got {1} "
+ "symbols with non-empty docs in the response",
----------------
ioeric wrote:
> drive by: I think this should be `vlog` or `dlog`.
Code completion also logs the number of results from sema, index, etc. using the `log()` call.
The added log message looks similar, so trying to be consistent with the rest of the code in this file.
Maybe we should turn all of them into `vlog` or `dlog`, but I'd rather leave it to a separate patch.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50727
More information about the cfe-commits
mailing list