[PATCH] D50727: [clangd] Fetch documentation from the Index during signature help

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added a comment.

looks good, a few nits.



================
Comment at: clangd/CodeComplete.cpp:742
+    llvm::DenseMap<SymbolID, std::string> FetchedDocs;
+    if (Index) {
+      LookupRequest IndexRequest;
----------------
nit: do we want to log anything here? It may be useful for debug.


================
Comment at: clangd/index/Index.h:65
 public:
+  static llvm::Optional<SymbolID> forDecl(const Decl &D);
+
----------------
We already have this similar function in clangd/AST.h.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D50727