[PATCH] D50372: Introduce the VTable interleaving scheme to the CFI design documentation

[Peter Collingbourne via Phabricator via cfe-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM except for a few spelling/grammar nits.



================
Comment at: clang/docs/ControlFlowIntegrityDesign.rst:361
+it starts by allocating two work lists, one initialized with all the offset-to-top entries of virtual tables in the order 
+computed in the last step, one initlized with all the RTTI entries in the same order. 
+
----------------
initialized


================
Comment at: clang/docs/ControlFlowIntegrityDesign.rst:374
+
+Then for each virtual funciton the algorithm goes through all the virtual tables in the previously computed order
+to collect all the relted entries into a virtual function list. 
----------------
function


================
Comment at: clang/docs/ControlFlowIntegrityDesign.rst:375
+Then for each virtual funciton the algorithm goes through all the virtual tables in the previously computed order
+to collect all the relted entries into a virtual function list. 
+After this step, there are the following virtual function lists:
----------------
related


================
Comment at: clang/docs/ControlFlowIntegrityDesign.rst:395
+
+Next, the algorithm picks the longest remaining virtual function list and append the whole list to the shortest work list
+until no function list is left, and pads the shorter work list so that they are of the same length. 
----------------
appends


================
Comment at: clang/docs/ControlFlowIntegrityDesign.rst:396
+Next, the algorithm picks the longest remaining virtual function list and append the whole list to the shortest work list
+until no function list is left, and pads the shorter work list so that they are of the same length. 
+In the example, f1 list will be first added to work list 1, then f2 list will be added 
----------------
lists are left


https://reviews.llvm.org/D50372