[PATCH] D50764: [AST] Make NullStmt final and give it factory functions
Stephen Kelly via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 15 13:02:34 PDT 2018
steveire accepted this revision.
steveire added a comment.
This revision is now accepted and ready to land.
This looks like a NFC change.
Given that the next patch moves these methods out of line, you might consider introducing them out of line here (and moving the constructors out of line). That would make the next patch easier to review because the addition of assertion handling would be move visible.
LGTM, but I'm new here, so you may want to wait for another reviewer if you wish.
Repository:
rC Clang
https://reviews.llvm.org/D50764
More information about the cfe-commits
mailing list