[PATCH] D50455: Continue emitting diagnostics after a fatal error

[Dmitry via Phabricator via cfe-commits]

Dmitry.Kozhevnikov added a comment.

In https://reviews.llvm.org/D50455#1193468, @ilya-biryukov wrote:

> I'm a bit worried that clang may emit too many irrelevant errors, because it may not cope nicely with those fatal errors, i.e. wasn't tested that thoroughly in that mode.


It sort of happens already: even if you have a fatal error in a preamble, diagnostics for the main file are still produced. This just expands it for the case the fatal error and the rest of the code happen to exist both in the preamble/main file.

> Nevertheless, I think this is moving clangd in the right direction and if we see too many irrelevant errors, we should look into improving clang to show less of those.

We've enabled it in CLion by default, hopefully, we'll get some feedback.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D50455