[PATCH] D50783: [CodeGen] Merge identical block descriptor global variables
Akira Hatanaka via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 15 09:38:15 PDT 2018
ahatanak added a comment.
A few points I forgot to mention:
- This optimization kicks in only in NonGC mode. I don't think we need to care much about GC anymore, so I think that's OK.
- There is a lot of redundancy among the copy/dispose helper function strings and the block layout string in the block descriptor name (they all encode the information about the captures), which can make the descriptor name long. If that becomes a problem, it's possible to encode the information in a way that shortens the descriptor name, but that would probably make the function that generates the name more complex.
Repository:
rC Clang
https://reviews.llvm.org/D50783
More information about the cfe-commits
mailing list