[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

[Artem Dergachev via Phabricator via cfe-commits]

NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: Szelethus.

I think this patch is in good shape.

In https://reviews.llvm.org/D32859#1187551, @baloghadamsoftware wrote:

> I do not see which lines exactly you commented


This was about the `replaceSymbol()` sub. You can traverse history using the History tab, or if there's still a greyed out comment you can push the |<< button on it to jump to the respective historical diff.

In any case, i think in current form `replaceSymbol()` is much easier to understand, but still deserves a short comment, maybe a small example, maybe a better name (the word "rebase" comes to mind).


https://reviews.llvm.org/D32859