[PATCH] D50713: [AST] Pack the unsigned of SubstTemplateTypeParmPackType into Type

[Erich Keane via Phabricator via cfe-commits]

erichkeane added inline comments.


================
Comment at: include/clang/AST/Type.h:1634
+
+    /// The number of template arguments in \c Arguments.
+    /// Intentionally not a bitfield since we have plenty of space left.
----------------
I would love it if we commented what a reasonable number for this is.  Additionally, we should probably make it 64 - NumTypeBits or something, to ensure that if NumTypeBits gets too large that we don't blow 64 bits here as well as communicate that it isn't necessary to keep this 32 bits.


Repository:
  rC Clang

https://reviews.llvm.org/D50713