[PATCH] D50652: [libcxx] By default, do not use internal_linkage to hide symbols from the ABI

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 14 06:54:15 PDT 2018


ldionne added a comment.

In https://reviews.llvm.org/D50652#1198885, @hans wrote:

> Oh, or could we do
>
>   -D_LIBCPP_HIDE_FROM_ABI=
>
>
> and just get regular odr linkage for these functions?


No, you do need to use `_LIBCPP_HIDDEN _LIBCPP_ALWAYS_INLINE` because of the issue described in http://lists.llvm.org/pipermail/llvm-dev/2018-July/124549.html. But yeah, Chromium could use this workaround.


Repository:
  rCXX libc++

https://reviews.llvm.org/D50652





More information about the cfe-commits mailing list