[PATCH] D50672: [ASTImporter] Change the return result of Decl import to Optional

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 14 00:30:47 PDT 2018


balazske added a comment.

This change is in conflict with our similar patch to introduce error handling in `ASTImporter`. That patch would be a much bigger one, because (almost) every import can fail, return of every `Import` (not only Decl) is changed from `X` to `Expected<X>`. After every import (inside the import functions too) the result needs to be checked always for error.


Repository:
  rC Clang

https://reviews.llvm.org/D50672





More information about the cfe-commits mailing list