[PATCH] D50341: [libcxx] Fix XFAILs for aligned allocation tests on older OSX versions

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 13 19:06:19 PDT 2018


vsapsai added a comment.

What about defining a feature for unsupported configurations? I've tried

  if '__cpp_aligned_new' not in macros or \
          intMacroValue(macros['__cpp_aligned_new']) < 201606:
      self.config.available_features.add('libcpp-no-aligned-new')

and `// UNSUPPORTED: libcpp-no-aligned-new`. Seems to be working but it's not sufficient. For example, clang-6 for old macOS versions would define `__cpp_aligned_new` but a test would fail. Still, we can use another feature, not necessarily macro-based. Though probably something like `libcpp-no-aligned-new` can replace `// UNSUPPORTED: c++98, c++03, c++11, c++14`.


Repository:
  rCXX libc++

https://reviews.llvm.org/D50341





More information about the cfe-commits mailing list