[PATCH] D50674: [libc++] Add missing #include in C11 features tests
Louis Dionne via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 13 15:54:30 PDT 2018
ldionne created this revision.
ldionne added a reviewer: mclow.lists.
Herald added a reviewer: EricWF.
Herald added subscribers: cfe-commits, dexonsmith, christof.
These #includes are quite important, since otherwise any
#if TEST_STD_VER > 14 && defined(TEST_HAS_C11_FEATURES)
checks are always false, and so we don't actually test for C11 support
in the standard library.
Repository:
rCXX libc++
https://reviews.llvm.org/D50674
Files:
libcxx/test/libcxx/language.support/has_c11_features.pass.cpp
libcxx/test/std/depr/depr.c.headers/float_h.pass.cpp
libcxx/test/std/language.support/support.limits/c.limits/cfloat.pass.cpp
Index: libcxx/test/std/language.support/support.limits/c.limits/cfloat.pass.cpp
===================================================================
--- libcxx/test/std/language.support/support.limits/c.limits/cfloat.pass.cpp
+++ libcxx/test/std/language.support/support.limits/c.limits/cfloat.pass.cpp
@@ -11,6 +11,8 @@
#include <cfloat>
+#include "test_macros.h"
+
#ifndef FLT_ROUNDS
#error FLT_ROUNDS not defined
#endif
Index: libcxx/test/std/depr/depr.c.headers/float_h.pass.cpp
===================================================================
--- libcxx/test/std/depr/depr.c.headers/float_h.pass.cpp
+++ libcxx/test/std/depr/depr.c.headers/float_h.pass.cpp
@@ -11,6 +11,8 @@
#include <float.h>
+#include "test_macros.h"
+
#ifndef FLT_ROUNDS
#error FLT_ROUNDS not defined
#endif
Index: libcxx/test/libcxx/language.support/has_c11_features.pass.cpp
===================================================================
--- libcxx/test/libcxx/language.support/has_c11_features.pass.cpp
+++ libcxx/test/libcxx/language.support/has_c11_features.pass.cpp
@@ -14,6 +14,9 @@
// _LIBCPP_HAS_C11_FEATURES - which is defined in <__config>
// They should always be the same
+#include <__config>
+#include "test_macros.h"
+
#ifdef TEST_HAS_C11_FEATURES
# ifndef _LIBCPP_HAS_C11_FEATURES
# error "TEST_HAS_C11_FEATURES is defined, but _LIBCPP_HAS_C11_FEATURES is not"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50674.160475.patch
Type: text/x-patch
Size: 1384 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180813/7878da16/attachment.bin>
More information about the cfe-commits
mailing list