[PATCH] D50652: [libcxx] By default, do not use internal_linkage to hide symbols from the ABI

[Reid Kleckner via Phabricator via cfe-commits]

rnk added a comment.

I'd prefer not to do this, since internal_linkage generates smaller, more debuggable code by default. I think the symbol table size increase may be specific to MachO, and it may be possible to work around this by changing ld64 to pool strings for symbols by default. I don't know enough about MachO to say if this is possible.

I also think the symbol table size problem may be limited to "large" users of C++: people with 500+ object files using libc++ in a DSO. I'm more comfortable imposing a cost on these users to ask them to opt in to some setting that disables internal_linkage and always_inline than I am leaving always_inline on by default, which adversely affects all users.


Repository:
  rCXX libc++

https://reviews.llvm.org/D50652