[PATCH] D50647: [Sema] fix -Wfloat-conversion test case.
Aaron Ballman via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 13 10:12:20 PDT 2018
On Mon, Aug 13, 2018 at 1:08 PM, Nick Desaulniers via Phabricator
<reviews at reviews.llvm.org> wrote:
> nickdesaulniers created this revision.
> nickdesaulniers added reviewers: aaron.ballman, gkistanova.
> Herald added a subscriber: cfe-commits.
>
> Fixes commit 6bbde717f7fb ("[SEMA] add more -Wfloat-conversion to
> compound assigment analysis").
Thank you for fixing this, but in the future, can you please put the
SVN revision number into the commit message rather than a git hash
(for code archaeology purposes)? Not everyone is on git yet. :-)
r339581 is the amended revision in this case.
~Aaron
>
> This test case was caught in postsubmit testing.
>
>
> Repository:
> rC Clang
>
> https://reviews.llvm.org/D50647
>
> Files:
> test/Sema/conversion.c
>
>
> Index: test/Sema/conversion.c
> ===================================================================
> --- test/Sema/conversion.c
> +++ test/Sema/conversion.c
> @@ -359,7 +359,7 @@
> void test_7676608(void) {
> float q = 0.7f;
> char c = 5;
> - f7676608(c *= q);
> + f7676608(c *= q); // expected-warning {{conversion}}
> }
>
> // <rdar://problem/7904686>
>
>
More information about the cfe-commits
mailing list