[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

[Hugo Gonzalez via Phabricator via cfe-commits]

hugoeg marked 8 inline comments as done.
hugoeg added inline comments.


================
Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:2
+// RUN: %check_clang_tidy %s abseil-no-internal-deps %t
+
+
----------------
hokein wrote:
> nit: please make sure the code follow LLVM code style, even for test code :)
what is this in reference too?
Will the test still work if I wrap the CHECK MESSAGE lines?


================
Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:11
+
+namespace absl {
+std::string StringsFunction (std::string s1){
----------------
hokein wrote:
> Since we have multiple abseil checks that might use these fake abseil declarations, I'd suggest pull out these to a common header, and include it in this test file.
do I just put the header file  in test/clang-tidy ?


https://reviews.llvm.org/D50542