r339074 - [lit, python] Always add quotes around the python path in lit

Hans Wennborg via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 13 04:54:24 PDT 2018


Merged to 7.0 in r339554.

On Tue, Aug 7, 2018 at 12:37 AM, Stella Stamenova via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
> Author: stella.stamenova
> Date: Mon Aug  6 15:37:45 2018
> New Revision: 339074
>
> URL: http://llvm.org/viewvc/llvm-project?rev=339074&view=rev
> Log:
> [lit, python] Always add quotes around the python path in lit
>
> Summary:
> The issue with the python path is that the path to python on Windows can contain spaces. To make the tests always work, the path to python needs to be surrounded by quotes.
>
> This is a companion change to: https://reviews.llvm.org/D50206
>
> Reviewers: asmith, zturner
>
> Subscribers: cfe-commits
>
> Differential Revision: https://reviews.llvm.org/D50281
>
> Modified:
>     cfe/trunk/test/Tooling/clang-diff-json.cpp
>
> Modified: cfe/trunk/test/Tooling/clang-diff-json.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Tooling/clang-diff-json.cpp?rev=339074&r1=339073&r2=339074&view=diff
> ==============================================================================
> --- cfe/trunk/test/Tooling/clang-diff-json.cpp (original)
> +++ cfe/trunk/test/Tooling/clang-diff-json.cpp Mon Aug  6 15:37:45 2018
> @@ -1,10 +1,10 @@
>  // RUN: clang-diff -ast-dump-json %s -- \
> -// RUN: | '%python' -c 'import json, sys; json.dump(json.loads(sys.stdin.read()), sys.stdout, sort_keys=True, indent=2)' \
> +// RUN: | %python -c 'import json, sys; json.dump(json.loads(sys.stdin.read()), sys.stdout, sort_keys=True, indent=2)' \
>  // RUN: | FileCheck %s
>
> -// CHECK: "begin": 301,
> +// CHECK: "begin": 311,
>  // CHECK: "type": "FieldDecl",
> -// CHECK: "end": 321,
> +// CHECK: "end": 319,
>  // CHECK: "type": "CXXRecordDecl",
>  class A {
>    int x;
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


More information about the cfe-commits mailing list