[PATCH] D50605: [ASTMatchers] Let hasAnyArgument also support CXXUnresolvedConstructExpr

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 12 14:20:24 PDT 2018


aaron.ballman added inline comments.


================
Comment at: include/clang/AST/ExprCXX.h:3436
   using const_arg_iterator = const Expr* const *;
+  using arg_const_range = llvm::iterator_range<const_arg_iterator>;
 
----------------
shuaiwang wrote:
> aaron.ballman wrote:
> > Please name this `const_arg_range` for consistency.
> `arg_const_range` is more widely in clang
`arg_const_range` makes no sense -- the range is of constant args, not an argument over a constant range. Also, it's weird to have `const_arg_iterator` with `arg_const_range` in the same class. I've cleaned up those few instances in r339527. Thanks for pointing this out!


Repository:
  rC Clang

https://reviews.llvm.org/D50605





More information about the cfe-commits mailing list