[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

George Karpenkov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 10 14:20:11 PDT 2018


george.karpenkov added inline comments.


================
Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:164
+  // - sizeof(dst)
+  if (Append && isSizeof(LenArg, DstArg))
+    return true;
----------------
george.karpenkov wrote:
> I am confused on what is happening in this branch and why is it bad. Could we add a commend?
Sorry I'm still confused about this branch: could you clarify?


https://reviews.llvm.org/D49722





More information about the cfe-commits mailing list