[PATCH] D50467: [SEMA] add more -Wfloat-conversion to compound assigment analysis

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman requested changes to this revision.
aaron.ballman added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/Sema/SemaChecking.cpp:10424
+      // We don't want to warn for system macro.
+      S.SourceMgr.isInSystemMacro(E->getOperatorLoc()))
+    // warn about dropping FP rank.
----------------
This looks incorrect to me -- this is testing the rank difference and that it is in a system macro (the `!` was dropped). If this didn't cause any tests to fail, we should add a test that would fail for it.


Repository:
  rC Clang

https://reviews.llvm.org/D50467