[PATCH] D49800: [clang-tidy: modernize] modernize-redundant-void-arg crashes when a function body is in a macro

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 10 05:56:02 PDT 2018


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

LG with a couple of nits. Do you need someone to commit the patch for you?



================
Comment at: clang-tidy/modernize/RedundantVoidArgCheck.cpp:241
+    SourceLocation End, Begin;
+    auto SM = Result.SourceManager;
+    auto TypeLoc = Lambda->getLambdaClass()->getLambdaTypeInfo()->getTypeLoc();
----------------
s/auto /SourceManager */


================
Comment at: clang-tidy/modernize/RedundantVoidArgCheck.cpp:242
+    auto SM = Result.SourceManager;
+    auto TypeLoc = Lambda->getLambdaClass()->getLambdaTypeInfo()->getTypeLoc();
+    End = SM->getSpellingLoc(TypeLoc.getLocEnd());
----------------
Use the actual type name here as well.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D49800





More information about the cfe-commits mailing list