[PATCH] D50415: [clangd] extend the publishDiagnostics response to send back fixits to the client directly as well (if requested)

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 10 05:11:31 PDT 2018


ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM with a small NIT.



================
Comment at: clangd/ClangdLSPServer.cpp:507
+        }
+        LSPDiag["clangd.fixes"] = std::move(ClangdFixes);
+      }
----------------
NIT: maybe avoid `.` and use something like `clangd_fixes`? having dots in the object keys might be awkward if someone tries to use those from javascript. (not that we have these use-cases now, but still)


https://reviews.llvm.org/D50415





More information about the cfe-commits mailing list