[PATCH] D50500: [clangd] Allow consuming limited number of items

[Eric Liu via Phabricator via cfe-commits]

ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/unittests/clangd/DexIndexTests.cpp:252
+  auto DocIterator = create(L0);
+  EXPECT_THAT(consume(*DocIterator, 42), ElementsAre(4, 7, 8, 20, 42, 100));
+
----------------
nit: maybe use the default parameter here?


================
Comment at: clang-tools-extra/unittests/clangd/DexIndexTests.cpp:260
+
+  auto Root = createAnd(createAnd(create(L1), create(L2)),
+                        createOr(create(L3), create(L4), create(L5)));
----------------
The AND iterator case doesn't seem to add more coverage. Maybe drop?


https://reviews.llvm.org/D50500