[PATCH] D50543: [libcxx] Mark charconv tests as failing for previous libcxx versions.

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 9 17:49:16 PDT 2018


vsapsai created this revision.
vsapsai added reviewers: mclow.lists, ldionne.
Herald added a reviewer: EricWF.
Herald added subscribers: dexonsmith, christof.

<charconv> was added in r338479. Previous libcxx versions don't have
this functionality and corresponding tests should be failing.


https://reviews.llvm.org/D50543

Files:
  libcxx/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp
  libcxx/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp


Index: libcxx/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp
===================================================================
--- libcxx/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp
+++ libcxx/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp
@@ -8,6 +8,15 @@
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11
+
+// XFAIL: with_system_cxx_lib=macosx10.13
+// XFAIL: with_system_cxx_lib=macosx10.12
+// XFAIL: with_system_cxx_lib=macosx10.11
+// XFAIL: with_system_cxx_lib=macosx10.10
+// XFAIL: with_system_cxx_lib=macosx10.9
+// XFAIL: with_system_cxx_lib=macosx10.8
+// XFAIL: with_system_cxx_lib=macosx10.7
+
 // <charconv>
 
 // to_chars_result to_chars(char* first, char* last, Integral value,
Index: libcxx/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp
===================================================================
--- libcxx/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp
+++ libcxx/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp
@@ -8,6 +8,15 @@
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11
+
+// XFAIL: with_system_cxx_lib=macosx10.13
+// XFAIL: with_system_cxx_lib=macosx10.12
+// XFAIL: with_system_cxx_lib=macosx10.11
+// XFAIL: with_system_cxx_lib=macosx10.10
+// XFAIL: with_system_cxx_lib=macosx10.9
+// XFAIL: with_system_cxx_lib=macosx10.8
+// XFAIL: with_system_cxx_lib=macosx10.7
+
 // <charconv>
 
 // from_chars_result from_chars(const char* first, const char* last,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50543.160041.patch
Type: text/x-patch
Size: 1652 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180810/ba7c6513/attachment.bin>


More information about the cfe-commits mailing list