[PATCH] D50341: [libcxx] Mark aligned allocation tests as XFAIL on old OSX versions

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 9 11:57:23 PDT 2018


ldionne added inline comments.


================
Comment at: libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_align.fail.cpp:15
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14, c++17
 // UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7, clang-3.8
----------------
vsapsai wrote:
> In what cases are we supposed to run these tests? Such extensive collection of unsupported C++ standards looks suspicious and I guess that is the reason why I haven't seen test failures with older libc++ dylibs.
That's an excellent question. I would assume those should be enabled in C++17 and above, I'm not sure why they're disabled. @mclow.lists was the one to introduce those tests, perhaps he can shed light on why they were disabled in C++17?


Repository:
  rCXX libc++

https://reviews.llvm.org/D50341





More information about the cfe-commits mailing list