[PATCH] D50175: [AArch64][NFC] better matching of AArch64 target in aarch64-cpus.c tests

[Oliver Stannard via Phabricator via cfe-commits]

olista01 added inline comments.


================
Comment at: test/Driver/aarch64-cpus.c:10
+// GENERIC: "-cc1"{{.*}} "-triple" "aarch64"{{.*}} "-target-cpu" "generic"
+// GENERIC-LE: "-cc1"{{.*}} "-triple" "aarch64--"{{.*}} "-target-cpu" "generic"
 
----------------
SjoerdMeijer wrote:
> olista01 wrote:
> > Why do these need new check prefixes? All of the RUN lines above are selecting little-endian, so I'd expect GENERIC and GENERIC-LE to be the same.
> Ok, good point. The output is slightly different. For the little-endian runs above the output is:
> 
>   "-triple" "aarch64"
> 
> and with "-target aarch64_be -mlittle-endian" the output is:
> 
>   "-triple" "aarch64--"
> 
> As we don't want to be too generic and match "aarch64{{.*}}", I will therefore change the GENERIC checks to match "aarch64{{[--]*}}", and indeed remove GENERIC-LE.
I think that works, but it's a strange way to write the regex. You have "-" twice inside a character set, which is the same as only having it once, so "[--]*" matches zero or more occurrences of "-". I'd suggest using something like "(--)?" which matches either "--" or nothing.


https://reviews.llvm.org/D50175