[PATCH] D50462: Try building complete AST after a fatal error was emitted if further diagnostics are expected

[Alex Lorenz via Phabricator via cfe-commits]

arphaman added a comment.

On a second look I think that there is value separating the concepts of 'producing diagnostics' after hitting the fatal error (which is SuppressAfterFatalError currently does), and trying to build a more complete AST.
For example,

- An editor client might not want to show the diagnostics after the fatal error has been reached to match the diagnostics observed during build, but it would benefit from a more complete AST for other editing features.
- Index-while-building: the compiler shouldn't show the diagnostics after a fatal error has been reached, but the indexer would be able to produce better indexing data from a more complete AST.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D50462