[PATCH] D50144: Add Windows support for the GNUstep Objective-C ABI V2.

Mandeep Singh Grang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 8 10:23:03 PDT 2018


mgrang added inline comments.


================
Comment at: lib/CodeGen/CGObjCGNU.cpp:3542
+      allSelectors.push_back(entry.first);
+    std::sort(allSelectors.begin(), allSelectors.end());
 
----------------
Please use llvm::sort instead of std::sort. See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements.


Repository:
  rC Clang

https://reviews.llvm.org/D50144





More information about the cfe-commits mailing list