[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

Gheorghe-Teodor Bercea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 8 05:44:48 PDT 2018


gtbercea added a comment.



> Ok, so you are already talking about performance. I think we should fix correctness first, in particular the compiler shouldn't complain whenever `<math.h>` is included.

This patch is concerned with calling device functions when you're on the device. The correctness issues you mention are orthogonal to this and should be handled by another patch. I don't think this patch should be held up any longer.


Repository:
  rC Clang

https://reviews.llvm.org/D47849





More information about the cfe-commits mailing list