[PATCH] D50385: [clangd] Collect symbol occurrences from AST.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 8 02:11:05 PDT 2018


ioeric added a comment.

2 high-level questions:

1. What's the reason for having a separate `SymbolOccurrenceSlab`? Could store occurrences as extra payload of `Symbol`?

2. Could we merge `SymbolOccurrenceCollector` into the existing `SymbolCollector`? They look a lot alike. Having another index data consumer seems like more overhead on the user side.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D50385





More information about the cfe-commits mailing list