[PATCH] D50410: Removing -debug-info-macros from option suggestions test

Arnaud Coomans via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 7 15:08:27 PDT 2018


acoomans created this revision.
acoomans added reviewers: cfe-commits, modocache.
Herald added subscribers: dexonsmith, JDevlieghere, mehdi_amini.

https://reviews.llvm.org/D46776 added support for "did you mean ...?" command line option suggestions. One of the tests was checking against the `-debug-info-macro` option, which was failing on the PS4 build bot. The same test would succeed again the `--help` and `--version` options.

>From https://llvm.org/devmtg/2013-11/slides/Robinson-PS4Toolchain.pdf, it looks like the PS4 SDK forces optimizations and could be disabling the `-debug-info-macro` altogether.

This diff removes `-debug-info-macro` altogether.

Note: untested since we do not have access to a PS4 with the SDK.


Repository:
  rC Clang

https://reviews.llvm.org/D50410

Files:
  test/Driver/unknown-arg.c


Index: test/Driver/unknown-arg.c
===================================================================
--- test/Driver/unknown-arg.c
+++ test/Driver/unknown-arg.c
@@ -14,7 +14,7 @@
 // RUN: FileCheck %s --check-prefix=CL-ERROR-DID-YOU-MEAN
 // RUN: %clang_cl -cake-is-lie -%0 -%d -HHHH -munknown-to-clang-option -print-stats -funknown-to-clang-option -c -Wno-unknown-argument -### -- %s 2>&1 | \
 // RUN: FileCheck %s --check-prefix=SILENT
-// RUN: not %clang -cc1as -hell --version -debug-info-macros 2>&1 | \
+// RUN: not %clang -cc1as -hell --version 2>&1 | \
 // RUN: FileCheck %s --check-prefix=CC1AS-DID-YOU-MEAN
 // RUN: not %clang -cc1asphalt -help 2>&1 | \
 // RUN: FileCheck %s --check-prefix=UNKNOWN-INTEGRATED


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50410.159603.patch
Type: text/x-patch
Size: 720 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180807/63a698ba/attachment.bin>


More information about the cfe-commits mailing list