[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions
Akira Hatanaka via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 7 11:49:42 PDT 2018
ahatanak added a comment.
I thought it was okay to skip the work done by `ResolveExceptionSpec` in IRGen as long as the exception specifications that are needed have already been resolved in Sema. But calling Sema::canThrow in Sema::CheckCompleteVariableDeclaration and storing the result in BlockDecl::Capture is clearly the better solution since it doesn't introduce the complexity introduced in the updated patch.
Repository:
rC Clang
https://reviews.llvm.org/D50152
More information about the cfe-commits
mailing list