[PATCH] D50154: [clangd] capitalize diagnostic messages

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 7 10:33:44 PDT 2018


arphaman added a comment.

In https://reviews.llvm.org/D50154#1191002, @dblaikie wrote:

> What's the motivation for clangd to differ from clang here? (& if the first
>  letter is going to be capitalized, should there be a period at the end? But
>  also the phrasing of most/all diagnostic text isn't in the form of complete
>  sentences, so this might not make sense)


It's mostly for the presentation purposes, to match the needs of our client. I first implemented it as an opt-in feature, but the consensus was to capitalize the messages all the time. 
I don't think it would make sense to insert the period at the end, because, as you said, not all diagnostics are complete sentences


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D50154





More information about the cfe-commits mailing list