[PATCH] D49223: [AST] Check described template at structural equivalence check.

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 6 10:21:25 PDT 2018


a.sidorin accepted this revision.
a.sidorin added a comment.

Hi Balazs,
I have only two nits. Otherwise, the patch is OK and can be committed without additional approval after the comments are fixed. Thank you!



================
Comment at: lib/AST/ASTStructuralEquivalence.cpp:1500
 
+bool StructuralEquivalenceContext::CommonCheckAtFinish(Decl *D1, Decl *D2) {
+  // Check for equivalent described template.
----------------
CheckCommonEquivalence/CheckKindSpecificEquivalence?


================
Comment at: lib/AST/ASTStructuralEquivalence.cpp:1643
 
     bool Equivalent = true;
 
----------------
`Equivalent = CommonCheckAtFinish(D1, D2) && SpecialCheckAtFinish(D1, D2))`?


Repository:
  rC Clang

https://reviews.llvm.org/D49223





More information about the cfe-commits mailing list