[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 6 01:01:52 PDT 2018
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D48903#1187605, @simark wrote:
> In https://reviews.llvm.org/D48903#1187596, @ilya-biryukov wrote:
>
> > This revision got 'reopened' and is now in the list of accepted revision. Should we close it again?
>
>
> It got reverted a second time because it was breaking a test on Windows. The new bit is the change to `test/PCH/case-insensitive-include.c`, so it would need review again. If somebody else could run the tests on Windows, it would make me a bit more confident too.
I see, thanks for the explanation.
LGTM for the update revision, given we have confirmation the tests pass on Windows.
Repository:
rC Clang
https://reviews.llvm.org/D48903
More information about the cfe-commits
mailing list